Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pius: 2.2.6 -> 2.2.7 #57366

Merged
merged 1 commit into from Mar 14, 2019
Merged

pius: 2.2.6 -> 2.2.7 #57366

merged 1 commit into from Mar 14, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pius/versions.

meta.description for pius is: '"PGP Individual UID Signer (PIUS), quickly and easily sign UIDs on a set of PGP keys"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/.pius-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/pius had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/.pius-keyring-mgr-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/pius-keyring-mgr had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/pius-party-worksheet had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/.pius-report-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin/pius-report had a zero exit code or showed the expected version
  • 0 of 7 passed binary check by having a zero exit code.
  • 0 of 7 passed binary check by having the new version present in output.
  • found 2.2.7 with grep in /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7
  • directory tree listing: https://gist.github.com/bde197cfe1c8ff7bde0a871c0b643948
  • du listing: https://gist.github.com/effce5e64211465923c2402e334231fa
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
pius

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A pius https://github.com/r-ryantm/nixpkgs/archive/a8ef5187856984de29a86ac5c481604bd04edf45.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7
ls -la /nix/store/jhbgjfnny3v8cdnnmwagfrspr42gad9r-pius-2.2.7/bin

cc @Fuuzetsu @kierdavis for testing.

@r-ryantm
pius: 2.2.6 -> 2.2.7
a8ef518 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/pius/versions
@kierdavis
Copy link
Contributor

kierdavis commented Mar 11, 2019 •
edited

I cannot test this because pius is broken in nixpkgs master and in the current nixpkgs release due to a missing dependency on pythonPackages.six:

[kier@coloris:/tmp]$ $(nix-build '<nixpkgs>' -A pius --no-out-link)/bin/pius
Traceback (most recent call last):
  File "/nix/store/r59whc1s9l6ik2fh0bj67d5l3kpxb9xn-pius-2.2.6/bin/.pius-wrapped", line 28, in <module>
    from six.moves import input
ImportError: No module named six.moves

Annoyingly, pius still uses distutils rather than setuptools which seems to happily install the package without checking that its dependencies are installed.

This is easily fixed by the below patch. What is the etiquette for applying fixes to r-ryantm PRs? Do I fork the branch that this PR is intending to merge and create a new PR of my own? EDIT: since the fix is unrelated to this PR, I'll create a separate PR that doesn't build off of this one.

diff --git a/pkgs/tools/security/pius/default.nix b/pkgs/tools/security/pius/default.nix
index 2a48bf2c2c6..465fcf36a77 100644
--- a/pkgs/tools/security/pius/default.nix
+++ b/pkgs/tools/security/pius/default.nix
@@ -19,6 +19,7 @@ pythonPackages.buildPythonApplication {
   '';
 
   buildInputs = [ perl ];
+  propagatedBuildInputs = with pythonPackages; [ six ];
 
   meta = {
     homepage = https://www.phildev.net/pius/;

@kierdavis
Copy link
Contributor

#57386

@kierdavis
Copy link
Contributor

#57386 has now been merged so this is good to go. It looks like the changes introduced by this PR work when merged with current master.

@ryantm ryantm merged commit 8c0abe7 into NixOS:master Mar 14, 2019
@ryantm
Copy link
Member

ryantm commented Mar 14, 2019

@kierdavis thanks!

@r-ryantm r-ryantm deleted the auto-update/pius branch March 15, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @kierdavis @ryantm @GrahamcOfBorg