Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smenu: relax platform from linux to unix #57427

Merged
merged 1 commit into from Mar 11, 2019
Merged

smenu: relax platform from linux to unix #57427

merged 1 commit into from Mar 11, 2019

Conversation

abathur
Copy link
Member

@abathur abathur commented Mar 11, 2019

Motivation for this change

Enable building smenu on additional platforms, as smenu claims to support any Unix (and built fine on macos with allowUnsupportedSystem = true). Close #57410.

Things done

Not in a position to clone nixpkgs to a system for further testing at the moment; I'm just making this change via github's (occasionally unhelpful...) online interface.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Mar 11, 2019

@GrahamcOfBorg build smenu

vcunat added a commit that referenced this pull request Mar 11, 2019
@vcunat vcunat merged commit a192cf3 into NixOS:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relax platform definition for smenu?
4 participants