Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg-full: fix darwin build #57342

Merged
merged 1 commit into from Mar 12, 2019
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

Let's actually check the darwin build:
@GrahamcOfBorg build ffmpeg-full

@xeji xeji merged commit 92917bf into NixOS:master Mar 12, 2019
xeji pushed a commit that referenced this pull request Mar 12, 2019
@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

backported to 19.03: 4fa4dbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants