Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

junkie: init at 2.8.0 #57510

Merged
merged 2 commits into from Mar 15, 2019
Merged

junkie: init at 2.8.0 #57510

merged 2 commits into from Mar 15, 2019

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Mar 12, 2019

Motivation for this change

Addition of a new networking tool: a programmable sniffer/DPI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Mar 14, 2019
View reviewed changes
pkgs/tools/networking/junkie/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/junkie/default.nix Show resolved Hide resolved
pkgs/tools/networking/junkie/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/junkie/default.nix Outdated Show resolved Hide resolved
@rixed
Copy link
Contributor Author

rixed commented Mar 15, 2019

Thank you so much for all the comments. That was my first attempt at packaging anything for Nix since I tested Nix about 7 or 8 years ago :)

@infinisil
Copy link
Member

Nice :D

Only thing I could complain about now is that the commits should be switched around, adding yourself to maintainers should come first because otherwise the package commit would reference your name which isn't present at that point yet

@rixed
Copy link
Contributor Author

rixed commented Mar 15, 2019

Only thing I could complain about now is that the commits should be switched around, adding yourself to maintainers should come first

Yes, I think that's how it is, at least according to my git log. Also according to github commit tab, assuming it displays the commit in the same order than git log. Am I missing something?

@infinisil
Copy link
Member

Ohh damn, it's GitHub's weird behavior where it doesn't display the commits in the right order sometimes when force pushing, see https://help.github.com/en/articles/why-are-my-commits-in-the-wrong-order

Alright everything good then :)

@rixed
Copy link
Contributor Author

rixed commented Mar 15, 2019

Oh I see. I was unaware of this behaviour.

@infinisil infinisil merged commit b81e42e into NixOS:master Mar 15, 2019
@rixed rixed deleted the junkie branch March 15, 2019 15:38
@infinisil
Copy link
Member

Does not build..

these derivations will be built:
  /nix/store/7p2h5w4glas3qx62grf80rd0svjmxqdg-source.drv
  /nix/store/1fqiw4zl8wm2rv4z99h61jj3v5qhmf19-junkie-2.8.0.drv
building '/nix/store/7p2h5w4glas3qx62grf80rd0svjmxqdg-source.drv'...

trying https://github.com/rixed/junkie/archive/v2.8.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   120    0   120    0     0    217      0 --:--:-- --:--:-- --:--:--   217
100 1233k    0 1233k    0     0   548k      0 --:--:--  0:00:02 --:--:--  997k
unpacking source archive /build/v2.8.0.tar.gz
hash mismatch in fixed-output derivation '/nix/store/rlyg71knykygmb5w3x4vvirl8x1jy8ik-source':
  wanted: sha256:16729cfxzvcq07vksrhgp89n7xh0z8rmyxwbm3k90kvdw3b7pdf9
  got:    sha256:0kfdjgch667gfb3qpiadd2dj3fxc7r19nr620gffb1ahca02wq31
cannot build derivation '/nix/store/1fqiw4zl8wm2rv4z99h61jj3v5qhmf19-junkie-2.8.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/1fqiw4zl8wm2rv4z99h61jj3v5qhmf19-junkie-2.8.0.drv' failed

@rixed
Copy link
Contributor Author

rixed commented Mar 16, 2019

OMG. Fixed in #57737

I would swear it used to work but now of course I failed to repro it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rixed @infinisil @GrahamcOfBorg