Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: 4.1.7.101 -> 4.1.8 #57511

Merged
merged 1 commit into from Mar 24, 2019
Merged

krita: 4.1.7.101 -> 4.1.8 #57511

merged 1 commit into from Mar 24, 2019

Conversation

f--t
Copy link
Contributor

@f--t f--t commented Mar 12, 2019

Motivation for this change
  1. upgraded krita
  2. fixed the issue regarding python dependency for building the extensions
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I think this should fix this, but I'm not sure if this is the right way to go for the python deps and extensions.

dotlambda
dotlambda approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

pkgs/applications/graphics/krita/default.nix Outdated Show resolved Hide resolved
worldofpeace
worldofpeace approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I've done to test.

  • Executed krita
  • Created a new document
  • Saved that document
  • After closing it was able to access again

@worldofpeace worldofpeace changed the title Fix/krita update krita: 4.1.7.101 -> 4.1.8 Mar 24, 2019
@worldofpeace worldofpeace merged commit 9437ec5 into NixOS:master Mar 24, 2019
@worldofpeace
Copy link
Contributor

Thanks for the update @f--t ❇️

@f--t f--t deleted the fix/krita-update branch October 20, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@f--t @worldofpeace @dotlambda @GrahamcOfBorg