WIP: libdrm, mesa: convert to meson, bump to HEAD #57562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
commented
Mar 15, 2019
| @@ -59,29 +60,25 @@ let | |||
| driDrivers = | |||
| (if dri_ == null | |||
| then optionals (elem "drm" eglPlatforms) defaultDriDrivers | |||
| else dri_) ++ lib.optional stdenv.isLinux "swrast"; | |||
There was a problem hiding this comment.
I'm not sure where/when to build gallium vs dri swrast... Also, do we not want llvmpipe/softpipe in here anywhere?
colemickens
commented
Mar 15, 2019
| # https://bugs.freedesktop.org/show_bug.cgi?id=35268 | ||
| (enableFeature (!stdenv.hostPlatform.isMusl) "glx-tls") | ||
| # (optional (!stdenv.hostPlatform.isMusl) "glx-tls") #? |
There was a problem hiding this comment.
not sure if this is still relevant, and/or what to do about it.
colemickens
commented
Mar 15, 2019
| fi | ||
|
|
||
| mkdir -p $dev/lib | ||
| cp -a $out/lib/pkgconfig $dev/lib/pkgconfig |
There was a problem hiding this comment.
I'm not sure what all is going on here and/or is necessary. I sort of hacked at this to get it to build.
|
See also #56199 |
|
Abandoning this due to #56199 and sending as a new PR for staging up with mesa, possibly. |
GrahamcOfBorg
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 501-1000
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a WIP to get early feedback --
libdrmandmesahave switched tomesonand required it when I tried to start building the upcoming release.This is an attempt to build the same configuration options, but with meson.
There were only a few flags that were either not obvious, or didn't have an equivalent.
There are some non-trivial differences in the post-build script, though, that I think might need some scrutiny.
cc: @vcunat
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)