Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test for StandardProduct3 #2094

Merged
merged 23 commits into from
Mar 13, 2019
Merged

A test for StandardProduct3 #2094

merged 23 commits into from
Mar 13, 2019

Conversation

eggrobin
Copy link
Member

The actual positions and velocities in the orbits are not tested for now; these tests will be added when support is added for the GRGS dialect (which uses m/s instead of the standard dm/s).

@@ -75,15 +76,22 @@ class StandardProduct3 {

StandardProduct3(std::filesystem::path const& filename, Dialect dialect);

std::vector<SatelliteIdentifier> const& satellites() const;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that this reflects the order of the data in the file.

@pleroy pleroy added the LGTM label Mar 13, 2019
@eggrobin eggrobin merged commit 3ce154a into mockingbirdnest:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants