Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glava: 1.5.8 -> 1.6.0 #57476

Merged
merged 1 commit into from Mar 12, 2019
Merged

glava: 1.5.8 -> 1.6.0 #57476

merged 1 commit into from Mar 12, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

@GrahamcOfBorg build glava

@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

I'm not sure if it is a new issue with this package but:

[nix-shell:~/.cache/nix-review/pr-57476]$ ./results/glava/bin/glava -V
GLava (glava) unknown (stable, unix/fhs)

@ryantm ryantm merged commit ca3b673 into NixOS:master Mar 12, 2019
@eadwu eadwu deleted the glava/1.6.0 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants