Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teradici PCoIP Client: init at 3.9.0~dev11 #57312

Closed
wants to merge 1 commit into from
Closed

Teradici PCoIP Client: init at 3.9.0~dev11 #57312

wants to merge 1 commit into from

Conversation

obadz
Copy link
Contributor

@obadz obadz commented Mar 10, 2019 •
edited

Two issues:

  1. I could not "unvendor" libQt5Declarative.so.5.6.3 as I can't find it in any Nix package (see https://stackoverflow.com/questions/55071459/how-can-i-build-libqt5declarative-so) cc: @ttuegel @acowley
  2. I cannot actually connect to an Amazon Workspace as I get this error: "The message is missing some content" (see https://communities.teradici.com/questions/10133/error-message-on-ubuntu-1604.html?childToView=10746#answer-10746)

Other than that, it's ready to roll :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@obadz obadz requested a review from ttuegel as a code owner March 10, 2019 22:55
@obadz obadz force-pushed the teradici-pcoip-client branch 2 times, most recently from a41389d to f9c20db Compare March 10, 2019 23:00
@obadz
teradici-pcoip-client: init at 3.9.0~dev11
4d1a1f1 
(and resurrect protobuf 3.0.2 in the process)
@obadz
Copy link
Contributor Author

obadz commented Mar 27, 2019

Regarding point (1), @ttuegel explained that this libQt5Declarative.so.5.6.3 is likely a proprietary shared library which can no longer be built from QT tarballs but which has apparently been built by some from this repo: https://github.com/qt/qtquick1/tree/5.6.2 — but that's not a Yak I'm prepared to shave now.

Still waiting for Teradici support to help with (2).

@ryantm ryantm added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jan 5, 2020
@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 04:44
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Artturin Artturin closed this Feb 2, 2023
@pedohorse pedohorse mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@obadz @ryantm @GrahamcOfBorg @Artturin