Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: link against "systemwide" liblcms2 #57313

Merged
merged 2 commits into from
Mar 11, 2019
Merged

ghostscript: link against "systemwide" liblcms2 #57313

merged 2 commits into from
Mar 11, 2019
+3 −5

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 10, 2019 •
edited
Loading

Motivation for this change

GS ships with a fork of lcms2 ("lcms2mt"), but the ABI separation
between the fork and the original seems insufficient. If libgs is linked
alongside liblcms2 (for example, this is the case with imagemagick) then
it will call into the original library instead of the fork, causing
segfaults.

Follow the example of both Arch and Debian in this regard -- they both
use the systemwide lib instead of the fork.

Fixes #55118. cc @Mic92 who merged #55634

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

delroth added 2 commits March 11, 2019 00:07
@delroth
ghostscript: link against "systemwide" liblcms2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
128bb7b 
GS ships with a fork of lcms2 ("lcms2mt"), but the ABI separation
between the fork and the original seems insufficient. If libgs is linked
alongside liblcms2 (for example, this is the case with imagemagick) then
it will call into the original library instead of the fork, causing
segfaults.

Follow the example of both Arch and Debian in this regard -- they both
use the systemwide lib instead of the fork.
@delroth
imagemagickBig: revert meta.broken to false
a9cf5c2
@delroth delroth mentioned this pull request Mar 10, 2019
Merged
erikarvstedt
erikarvstedt approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Thanks for the fix!

@Mic92 Mic92 merged commit c08f808 into NixOS:master Mar 11, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 11, 2019

I suppose we also should backport this?

@delroth
Copy link
Contributor Author

delroth commented Mar 11, 2019

@Mic92 👍

@Mic92 Mic92 mentioned this pull request Mar 11, 2019
Merged
10 tasks
@erikarvstedt erikarvstedt mentioned this pull request Mar 11, 2019
Closed
andersk added a commit to andersk/nixpkgs that referenced this pull request Mar 26, 2019
@andersk
imagemagick7Big: Revert meta.broken to false
a2aba3a 
imagemagickBig and imagemagick7Big were marked broken in NixOS#55634 due
to NixOS#55118.  NixOS#57313 fixed the bug but reverted the broken bit only on
imagemagickBig.  Revert it on imagemagick7Big too.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk mentioned this pull request Mar 26, 2019
Merged
10 tasks
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Mar 27, 2019
@andersk @veprbl
imagemagick7Big: Revert meta.broken to false (NixOS#58414)
0a88820 
imagemagickBig and imagemagick7Big were marked broken in NixOS#55634 due
to NixOS#55118.  NixOS#57313 fixed the bug but reverted the broken bit only on
imagemagickBig.  Revert it on imagemagick7Big too.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikarvstedt erikarvstedt

@the-kenny the-kenny

@viric viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @Mic92 @erikarvstedt @GrahamcOfBorg