Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: 3.24.5 -> 3.24.7 #57541

Merged
merged 1 commit into from Mar 14, 2019
Merged

gtk3: 3.24.5 -> 3.24.7 #57541

merged 1 commit into from Mar 14, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 12, 2019

Motivation for this change

http://ftp.acc.umu.se/pub/gnome/sources/gtk+/3.24/gtk+-3.24.6.news
http://ftp.acc.umu.se/pub/gnome/sources/gtk+/3.24/gtk+-3.24.7.news

Export symbols patch "actually" seems
to no longer be required, drop it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

hedning
hedning approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nothing worrying in gtk's issue tracker 👍

@dtzWill dtzWill merged commit 941859d into NixOS:staging Mar 14, 2019
@dtzWill dtzWill deleted the update/gtk-3.24.7 branch March 14, 2019 19:20
@vcunat
Copy link
Member

vcunat commented Mar 16, 2019

Right, .6 seems the first of 3.24.x to contain the patch: https://gitlab.gnome.org/GNOME/gtk/commit/c830ab2d55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @vcunat @hedning @GrahamcOfBorg