Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.poetry: Fix build #57408

Merged
merged 1 commit into from Mar 11, 2019
Merged

pythonPackages.poetry: Fix build #57408

merged 1 commit into from Mar 11, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 11, 2019

Motivation for this change

Fixes #57398

@kierdavis Can you test the resulting binary?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil requested a review from FRidh as a code owner March 11, 2019 16:03
Copy link
Contributor

@kierdavis kierdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me (tested poetry install and poetry run on an existing python project).

Thanks! 👍

@Mic92
Copy link
Member

Mic92 commented Mar 11, 2019

Is a backport to 19.03 required?

@kierdavis
Copy link
Contributor

@Mic92 Thanks! Yes, this package needs fixing in release-19.03 too.

@Mic92
Copy link
Member

Mic92 commented Mar 11, 2019

[detached HEAD fc40f61] pythonPackages.poetry: Fix build
Author: Silvan Mosberger infinisil@icloud.com
Date: Mon Mar 11 16:49:22 2019 +0100
1 file changed, 3 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants