Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: specify option types, add tests #57550

Merged
merged 2 commits into from Mar 28, 2019
Merged

nixos/mysql: specify option types, add tests #57550

merged 2 commits into from Mar 28, 2019

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

Prevent bugs, as mentioned in
#56720 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@florianjacob florianjacob mentioned this pull request Mar 12, 2019
Merged
10 tasks
@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test mysql

@florianjacob florianjacob marked this pull request as ready for review March 13, 2019 14:37
@aanderse
Copy link
Member

PS. @ryantm have you had any thoughts on #50403? Any thoughts from you, @florianjacob?

@aanderse
Copy link
Member

@GrahamcOfBorg test mysql

@infinisil infinisil merged commit 9d4a6cc into NixOS:master Mar 28, 2019
@schneefux schneefux mentioned this pull request Mar 30, 2019
Closed
@florianjacob florianjacob deleted the typed-mysql-options branch March 31, 2019 12:49
@flokli flokli mentioned this pull request May 21, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@florianjacob @aanderse @flokli @infinisil @GrahamcOfBorg