Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tamsyn: init at 1.11 #57482

Merged
merged 4 commits into from Mar 13, 2019
Merged

tamsyn: init at 1.11 #57482

merged 4 commits into from Mar 13, 2019

Conversation

robertseaton
Copy link
Contributor

Motivation for this change

Wanting to look like a l33t hackerman at Starbucks, needing a suitable bitmap font.

Things done
  • Created build file fonts/tamsyn/default.nix
  • Edited all-packages.nixto add package
  • Edited maintainer-list.nix to add self as maintainer
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Mar 12, 2019

LGTM! :)

ryantm
ryantm requested changes Mar 12, 2019
View reviewed changes
pkgs/data/fonts/tamsyn/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/tamsyn/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/tamsyn/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

@GrahamcOfBorg build tamsyn

ryantm and others added 3 commits March 12, 2019 11:43
@ryantm @robertseaton
tamsyn: refactor
519515d 
Co-Authored-By: robertseaton <robbpseaton@gmail.com>
@ryantm @robertseaton
tamsyn: refactor
6de2a1d 
Co-Authored-By: robertseaton <robbpseaton@gmail.com>
@ryantm @robertseaton
tamsyn: refactor
f61b465 
Co-Authored-By: robertseaton <robbpseaton@gmail.com>
@ryantm
Copy link
Member

ryantm commented Mar 13, 2019

@GrahamcOfBorg build tamsyn

@ryantm ryantm merged commit 402e7f9 into NixOS:master Mar 13, 2019
@ryantm
Copy link
Member

ryantm commented Mar 13, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robertseaton @dtzWill @ryantm @GrahamcOfBorg @Janik-Haag