Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: 3.5.2 -> 3.5.3 #57400

Closed
wants to merge 1 commit into from
Closed

R: 3.5.2 -> 3.5.3 #57400

wants to merge 1 commit into from

Conversation

jabranham
Copy link
Contributor

Motivation for this change

Upstream release

There was this warning during the build but things seem to work fine anyway:

./configure: line 11093: /usr/bin/file: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jabranham jabranham requested a review from peti as a code owner March 11, 2019 15:12
@jabranham jabranham mentioned this pull request Mar 11, 2019
Closed
10 tasks
@peti
Copy link
Member

peti commented Mar 13, 2019

Merged to r-updates in e8cf52405fda687b782ef67532ae0a0bce1c30b8. Test builds will take place at https://hydra.nixos.org/jobset/nixpkgs/r-updates.

@peti peti self-assigned this Mar 13, 2019
@peti peti closed this in 1e354a7 Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees

@peti peti

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jabranham @peti @GrahamcOfBorg