Skip to content

pgcli: Patch tests #57402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2019
Merged

pgcli: Patch tests #57402

merged 1 commit into from
Mar 12, 2019
+11 −1

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 11, 2019 •
edited
Loading

Motivation for this change

Patches the tests until the next pgcli release fixes them

Should be backported to 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@srhb srhb force-pushed the pgcli-test-typeerror branch from cff75a4 to 5471f8d Compare March 11, 2019 15:22
@srhb srhb changed the title pkgcli: Patch tests pgcli: Patch tests Mar 11, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from dywedir March 11, 2019 15:49
@xeji
Copy link
Contributor

xeji commented Mar 11, 2019

Travis CI fail - weird, let's try again
@GrahamcOfBorg eval

@xeji xeji merged commit f3c66bb into NixOS:master Mar 12, 2019
xeji pushed a commit that referenced this pull request Mar 12, 2019
@srhb @xeji
pgcli: Patch tests (#57402)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8d9dd03 
(cherry picked from commit f3c66bb)
@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

backported: 8d9dd03

@Ma27 Ma27 mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @xeji @GrahamcOfBorg