Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picotts: init at 2018-10-19 #57486

Merged
merged 1 commit into from Apr 2, 2019
Merged

picotts: init at 2018-10-19 #57486

merged 1 commit into from Apr 2, 2019

Conversation

canndrew
Copy link
Contributor

Motivation for this change

I wanted to be able to use this program: https://github.com/naggety/picotts

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Mar 12, 2019
View reviewed changes
pkgs/tools/audio/picotts/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/picotts/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

@GrahamcOfBorg build picotts

@canndrew
Copy link
Contributor Author

@ryantm Sorry for the delay. I've committed those changes.

@ryantm
Copy link
Member

ryantm commented Apr 2, 2019

@GrahamcOfBorg build picotts

@ryantm ryantm merged commit 4d160c3 into NixOS:master Apr 2, 2019
@ryantm
Copy link
Member

ryantm commented Apr 2, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@canndrew @ryantm @GrahamcOfBorg