Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: better support for logitech devices and update relevant packages #57337

Merged
merged 5 commits into from Apr 3, 2019
Merged

nixos: better support for logitech devices and update relevant packages #57337

merged 5 commits into from Apr 3, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I got a new mouse that solaar didn't detect properly so here are updates to ltunify and solaar as well as a super basic NixOS module that configures the udev rules.

Cc: @spinus @ysndr @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Cc'ing @samueldr and @cleverca22 due to #57592 which was done concurrently with this.

@peterhoeg peterhoeg requested a review from FRidh as a code owner March 19, 2019 02:00
@peterhoeg peterhoeg merged commit 61613a2 into NixOS:master Apr 3, 2019
@peterhoeg peterhoeg deleted the m/logitech branch April 3, 2019 13:20
@spinus
Copy link
Member

spinus commented Apr 3, 2019

nice! Thanks @peterhoeg!

@peterhoeg peterhoeg restored the m/logitech branch April 4, 2019 03:01
@peterhoeg peterhoeg deleted the m/logitech branch April 7, 2019 13:18
@peterhoeg peterhoeg restored the m/logitech branch April 8, 2019 03:34
@peterhoeg peterhoeg deleted the m/logitech branch April 8, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@abbradar abbradar Awaiting requested review from abbradar

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @spinus @GrahamcOfBorg @r-ryantm