Skip to content

nixos: better support for logitech devices and update relevant packages #57337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2019
Merged

nixos: better support for logitech devices and update relevant packages #57337

merged 5 commits into from
Apr 3, 2019
+76 −16

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I got a new mouse that solaar didn't detect properly so here are updates to ltunify and solaar as well as a super basic NixOS module that configures the udev rules.

Cc: @spinus @ysndr @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg peterhoeg requested a review from infinisil as a code owner March 11, 2019 05:13
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Mar 11, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar March 11, 2019 05:28
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2019
@peterhoeg
Copy link
Member Author

Cc'ing @samueldr and @cleverca22 due to #57592 which was done concurrently with this.

r-ryantm and others added 5 commits March 19, 2019 09:58
@r-ryantm @peterhoeg
python37Packages.xcffib: 0.6.0 -> 0.7.0
ce7db15 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/python3.7-xcffib/versions
@peterhoeg
ltunify: 20140331 -> 20180330

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5751d9d
@peterhoeg
solaar: minor cleanups
4f3e834
@peterhoeg
logitech-udev-rules: init at 20190130
86cff5f
@peterhoeg
logitech (nixos): support module for logitech input devices
fe97297
@peterhoeg peterhoeg requested a review from FRidh as a code owner March 19, 2019 02:00
@peterhoeg peterhoeg merged commit 61613a2 into NixOS:master Apr 3, 2019
@peterhoeg peterhoeg deleted the m/logitech branch April 3, 2019 13:20
@spinus
Copy link
Member

spinus commented Apr 3, 2019

nice! Thanks @peterhoeg!

@peterhoeg peterhoeg restored the m/logitech branch April 4, 2019 03:01
@peterhoeg peterhoeg deleted the m/logitech branch April 7, 2019 13:18
@peterhoeg peterhoeg restored the m/logitech branch April 8, 2019 03:34
@peterhoeg peterhoeg deleted the m/logitech branch April 8, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

@abbradar abbradar

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @spinus @GrahamcOfBorg @r-ryantm