Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreutils: 8.30 -> 8.31, touchups #57339

Merged
merged 1 commit into from Mar 17, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 11, 2019

Motivation for this change

Release notes:

https://savannah.gnu.org/forum/forum.php?forum_id=9394

Touchups:

  • enable tests w/musl (disable 2 gnulib tests)
  • improve tests we modify: use exit code 77 to
    indicate test skipped (causing it to be reportd as SKIP)

Note: Not yet on mirrors, but can be (manually) fetched from primary

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Release notes:

https://savannah.gnu.org/forum/forum.php?forum_id=9394

Touchups:
* enable tests w/musl (disable 2 gnulib tests)
* improve tests we modify: use exit code 77 to
  indicate test skipped (causing it to be reportd as SKIP)

Note: Not yet on mirrors, but can be (manually) fetched from primary
@dtzWill
Copy link
Member Author

dtzWill commented Mar 14, 2019

(ty for the reviewer suggestions, github ^_^)

@dtzWill dtzWill merged commit 5506691 into NixOS:staging Mar 17, 2019
@dtzWill dtzWill deleted the update/coreutils-8.31 branch March 17, 2019 05:51
@alyssais alyssais mentioned this pull request Apr 21, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants