Skip to content

lightdm: disable writing dmrc files to home #57338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2019
Merged

lightdm: disable writing dmrc files to home #57338

merged 1 commit into from
Mar 14, 2019
+12 −4

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Mar 11, 2019 •
edited
Loading

Can cause issues where lightdm prefers the last saved session in .dmrc
even if it doesn't exist anymore, preventing people from logging in to
a session.

Motivation for this change

IMHO .dmrc don't really have a place in NixOS
and with AccountsService I don't think they'll be missed.

Patch is from fedora packaging, is actually this upstream pr canonical/lightdm#5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested a review from ocharles March 11, 2019 05:35
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2019
@worldofpeace
lightdm: disable writing dmrc files to home
4ebdf05 
Can cause issues where lightdm prefers the last saved session in .dmrc
even if it doesn't exist anymore, preventing people from logging in to
a session.
@worldofpeace worldofpeace force-pushed the lightdm/disable-dmrc branch from fc40dc1 to 4ebdf05 Compare March 13, 2019 02:49
@worldofpeace worldofpeace requested a review from jtojnar March 14, 2019 01:10
@worldofpeace worldofpeace merged commit 44298e7 into NixOS:master Mar 14, 2019
@worldofpeace
Copy link
Contributor Author

Backporting because it "breaks" things for people switching desktops.

@worldofpeace worldofpeace deleted the lightdm/disable-dmrc branch March 14, 2019 01:20
@worldofpeace
Copy link
Contributor Author

Backported in 9055b33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@dtzWill dtzWill

@ocharles ocharles

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @dtzWill @GrahamcOfBorg