Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord: 0.0.8 -> 0.0.9 #57528

Merged
merged 1 commit into from Mar 12, 2019
Merged

Discord: 0.0.8 -> 0.0.9 #57528

merged 1 commit into from Mar 12, 2019

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Mar 12, 2019 •
edited

Motivation for this change

Discord becomes unusable when the version is bumped. Could this be backported?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cleverca22
Copy link
Contributor

@GrahamcOfBorg build discord

@GrahamcOfBorg GrahamcOfBorg requested a review from MP2E March 12, 2019 17:26
@baracoder
Copy link
Contributor

It is working. 👍
It is a pain that they disable the old version immediately.

@worldofpeace
Copy link
Contributor

It is working. +1
It is a pain that they disable the old version immediately.

See #54003 discussion for possible solutions for this problem.

worldofpeace
worldofpeace suggested changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute in commit msg should be "discord"

@worldofpeace
Copy link
Contributor

Discord becomes unusable when the version is bumped. Could this be backported?

Yes, all updates to discord will need to be backported. I can perform this for you once it is merged.

@ar1a
Copy link
Contributor Author

ar1a commented Mar 12, 2019

@worldofpeace thanks for the input, all done!

@worldofpeace worldofpeace merged commit 24c02a0 into NixOS:master Mar 12, 2019
@worldofpeace
Copy link
Contributor

@ar1a Thank you ❇️

@worldofpeace worldofpeace mentioned this pull request Mar 12, 2019
Closed
10 tasks
@MP2E
Copy link

MP2E commented Mar 12, 2019

Thank you for fast-tracking this change! Would prefer our users have minimal disruptions

@worldofpeace
Copy link
Contributor

Thank you for fast-tracking this change! Would prefer our users have minimal disruptions

Yep, try my best to fast track this package because of the disruption it causes

Backported in:

@leo60228
Copy link
Member

leo60228 commented Mar 22, 2019 •
edited

Uh, this seems to be broken for me. I'm using it on an older unstable (just via callPackage) and it's erroring due to the lack of a name attribute. I copy/pasted it from the previous commit and it seems to work.

@worldofpeace
Copy link
Contributor

Uh, this seems to be broken for me. I'm using it on an older unstable (just via callPackage) and it's erroring due to the lack of a name attribute. I copy/pasted it from the previous commit and it seems to work.

I've built of versions of discord on all the active branches that the change was backported to and I cannot reproduce this issue.

This could have been a problem with an older revision.
If you have any problems feel free to open an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ar1a @cleverca22 @baracoder @worldofpeace @MP2E @leo60228 @GrahamcOfBorg