Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ngrok update + update script #57536

Merged
merged 3 commits into from Mar 19, 2019
Merged

Ngrok update + update script #57536

merged 3 commits into from Mar 19, 2019

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 12, 2019

Motivation for this change
  • Uses immutable URL instead of mutable to prevent future breakage
  • Update script should make maintenance easier
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji xeji mentioned this pull request Mar 15, 2019
Closed
6 tasks
@roberth roberth mentioned this pull request Mar 17, 2019
Closed
10 tasks
@bobvanderlinden
Copy link
Member

The update script is very much appreciated!

@bobvanderlinden
Copy link
Member

You could already bump the version to .18 from what I gathered in my pr. Though that'll happen automatically anyway. Will give this a go tomorrow (currently on phone).

@roberth
Copy link
Member Author

roberth commented Mar 17, 2019

Thanks! Updated.

It's not fully automatic, unless someone runs a generic script that tries every update script. Afaik, r-ryantm only checks repology.

@bobvanderlinden
Copy link
Member

Works for me!:

nix build ngrok-2 -f .
result/bin/ngrok http 80

The update script also works. It resulted in the same versions.json when I first removed versions.json.

@bobvanderlinden
Copy link
Member

It might be possible to use the more standardized(?) update script that some other packages are also using. See for instance Firefox https://github.com/nixos/nixpkgs/blob/136126ceaeb8cc21166a0f76c05aaaeb4ff1755a/pkgs/applications/networking/browsers/firefox-bin/default.nix#L194-L200

I can have a look at this later this week.

@roberth roberth mentioned this pull request Mar 19, 2019
Closed
@roberth
Copy link
Member Author

roberth commented Mar 19, 2019

I've split that task off into an issue #57898

@roberth roberth merged commit 2f41084 into NixOS:master Mar 19, 2019
@roberth roberth deleted the ngrok-update branch March 19, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @bobvanderlinden @GrahamcOfBorg