Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.weasyprint: init at 45 #57377

Merged
merged 1 commit into from May 22, 2019
Merged

pythonPackages.weasyprint: init at 45 #57377

merged 1 commit into from May 22, 2019

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

add WeasyPrint to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier requested a review from FRidh as a code owner March 11, 2019 12:31
@dotlambda
Copy link
Member

We'll have to wait until #56839 is merged.

@risicle
Copy link
Contributor

risicle commented Apr 13, 2019

#56839 is merged, but for me now on master, the python3.7-CairoSVG-2.3.0 dependency fails its isort-check test. Non-nixos linux x86_64.

@elohmeier
Copy link
Contributor Author

@risicle Same for me on NixOS.

@dotlambda
Copy link
Member

for me now on master, the python3.7-CairoSVG-2.3.0 dependency fails its isort-check test

fixed in bc14eed

@elohmeier Once you rebase your branch on master, you'll see that weasyprint fails to build with pytest: command not found due to #57377 (comment).

@risicle
Copy link
Contributor

risicle commented Apr 13, 2019

@dotlambda : nice - was working on a fix myself - will drop that commit - but I'm also finding pythonPackages.qiskit and pythonPackages.pygal which depend on it are failing to build now. Should have a PR soon.

@elohmeier
Copy link
Contributor Author

@dotlambda thanks for your support! I've rebased and was able to build successfully now.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.weasyprint python3.pkgs.weasyprint

@FRidh FRidh requested a review from dotlambda May 12, 2019 18:09
@FRidh
Copy link
Member

FRidh commented May 12, 2019

@GrahamcOfBorg build python2.pkgs.weasyprint python3.pkgs.weasyprint

@risicle
Copy link
Contributor

risicle commented May 12, 2019

Also builds & tests pass for me on macos 10.13.

@elohmeier
Copy link
Contributor Author

elohmeier commented May 22, 2019 •
edited

I think there are no open tasks for this package, can we get this merged? @dotlambda @FRidh

@FRidh FRidh merged commit de9b100 into NixOS:master May 22, 2019
@austinbutler austinbutler mentioned this pull request Apr 13, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elohmeier @dotlambda @risicle @FRidh @GrahamcOfBorg