Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nspr: patch out timestamp-based impurities #57552

Closed
wants to merge 1 commit into from
Closed

nspr: patch out timestamp-based impurities #57552

wants to merge 1 commit into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Mar 13, 2019 •
edited

Motivation for this change

https://r13y.com/diff/9c582ff3a3e9892dc2ae5d017110cfbac0f7d83d8614e4e9ff436a5467d46013-54f2851d51fb8de80f54619cd6249fc00f93119d092b34dab5d7a48d2ccfce4c.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build nspr

cc @grahamc for the reproducibility project, as this package appears to have no maintainer nor regular committer

@Ekleog Ekleog changed the title nspr: remove impurity nspr: patch out timestamp-based impurities Mar 13, 2019
@flokli flokli requested a review from andir March 15, 2019 09:29
@Ekleog Ekleog force-pushed the nspr-impurity branch 2 times, most recently from 364a62b to 16fc9ec Compare March 15, 2019 12:26
andir
andir approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the same build multiple times with --check after the initial build.

It also evals just fine here.

pkgs/development/libraries/nspr/default.nix
@@ -22,6 +22,10 @@ stdenv.mkDerivation {
substituteInPlace configure.in --replace '@executable_path/' "$out/lib/"
'';

# Avoid timestamp-based impurity
# Patch proposed upstream on 2019-03-15 to dev-tech-nspr@lists.mozilla.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find that message on the archives yet. Is the list moderated?

@andir
Copy link
Member

andir commented Mar 17, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build nspr

@andir
Copy link
Member

andir commented Mar 17, 2019

I think we can close this as it was already done in 885d1df.

@Ekleog
Copy link
Member Author

Ekleog commented Mar 17, 2019

Oh right, hadn't noticed, thanks!

@Ekleog Ekleog closed this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@andir andir andir approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @andir @flokli @GrahamcOfBorg