Skip to content

vim-plugins: typo propogatedBuildInputs -> propagatedBuildInputs #57553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Mar 13, 2019

Motivation for this change

I was adding a package and had propogatedBuildInputs and went to look for examples and found that no other package except mine and this spells it like that.... (amusingly if you grep too much of your system you will find there are other programs that have the misspelling 'propogated' in them)

Things done

Used the worldly accepted spelling of propagated
I ran the nox-review wip on it successfully
Spent way too much time trying to figure out all of this github/gpg/nixpkgs stuff
Learned how to spell propagated in English

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 13, 2019
@infinisil infinisil merged commit 5cc7ce9 into NixOS:master Mar 14, 2019
@Kiwi Kiwi deleted the vim-plugins-fix branch June 20, 2019 22:41
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants