Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: Add preferredAddressTypes option to apiserver #57523

Merged
merged 2 commits into from May 18, 2019
Merged

nixos/kubernetes: Add preferredAddressTypes option to apiserver #57523

merged 2 commits into from May 18, 2019

Conversation

markus2342
Copy link
Contributor

Motivation for this change

The --preferred-address-types option in the kubernetes apiserver enables the user to specify whether other kubernetes nodes should be connected to through e.g. their hostname or node IP.
The default prefers hostname which can lead to errors in some setups, where the hostname does not resolve.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Apr 29, 2019

In general, I would prefer to get rid of all these NixOS options in favor of *.extraOpts -- we can add validations as needed in unexposed functions without increasing the number of options. There is some argument for retaining the options whose values we need to refer to from elsewhere in NixOS modules, but I don't think this is really the case here. I'm inclined to say that extraOpts should suffice in this case. any particular reason to prioritize this one specifically?

@globin globin merged commit a1dcac5 into NixOS:master May 18, 2019
@globin globin deleted the kube-apiserver-preferred-address-types branch May 18, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markus2342 @srhb @globin @GrahamcOfBorg