Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it87: init at 2018-08-14 #57522

Merged
merged 1 commit into from Mar 24, 2019
Merged

it87: init at 2018-08-14 #57522

merged 1 commit into from Mar 24, 2019

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

The upstream (kernel) it87 driver is missing support for several modern chips. One of which being the IT8665e, which one of our machines has.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

@GrahamcOfBorg build linuxPackages_5_0.it87
@GrahamcOfBorg build linuxPackages_4_20.it87
@GrahamcOfBorg build linuxPackages_4_19.it87
@GrahamcOfBorg build linuxPackages_4_14.it87
@GrahamcOfBorg build linuxPackages_4_9.it87
@GrahamcOfBorg build linuxPackages_4_4.it87

@veprbl veprbl merged commit 04727cc into NixOS:master Mar 24, 2019
@veprbl
Copy link
Member

veprbl commented Mar 24, 2019

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @veprbl @GrahamcOfBorg