Skip to content

dockerTools.buildImage.runAsRoot: preserve layers ordering at image unpacking #57505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

dockerTools.buildImage.runAsRoot: preserve layers ordering at image unpacking #57505

merged 1 commit into from
Mar 22, 2019
+1 −1

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Mar 12, 2019

This patch preserves the ordering of layers of a parent image when the
image is unpacked.

Fixes #55290

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nlewo
dockerTools.buildImage.runAsRoot: preserve layers ordering at image u…
fe68608 
…npacking

This patch preserves the ordering of layers of a parent image when the
image is unpacked.

Fixes NixOS#55290
@nlewo nlewo mentioned this pull request Mar 12, 2019
Closed
@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 12, 2019
@roberth roberth requested a review from grahamc March 17, 2019 21:22
@srhb srhb added this to the 19.03 milestone Mar 19, 2019
@nlewo nlewo merged commit 2b9aa0a into NixOS:master Mar 22, 2019
@nlewo
Copy link
Member Author

nlewo commented Mar 22, 2019

Backported to 19.03 (8002a7f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
19.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @srhb @GrahamcOfBorg