Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-manager{,-qt}: update #57393

Merged
merged 2 commits into from Mar 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 12, 2019

@GrahamcOfBorg build yubikey-manager yubikey-manager-qt

@benley benley merged commit e398c92 into NixOS:master Mar 12, 2019
@benley
Copy link
Member

benley commented Mar 12, 2019

Whoops, I accidentally hit "squash and merge" instead of letting it do a normal merge; sorry for messing up your nice commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants