Can we get throws instead? I don't like just removing things without warning (especially on stable, even when possibly nobody is using it)

@infinisil fixed. All previously used attribute names for older citrix versions now break with a proper error message. All currently deprecated attribute names should be removed before 19.09 then.

That looks fine to me @Ma27.

@infinisil, I worry this policy of adding throws for every old version is going to create clutter in all-packages.nix. Technically we should also add citrix_receiver_13_6_0, citrix_receiver_13_5_0, and citrix_receiver_13_4_0 if we go down that route. I think maybe throws are fine for renamed attributes but not required for version specific attributes?

For what it's worth, keeping old versions had nothing to do with Citrix's EOL schedule. Rather it was to work around bugs that they would introduce and not fix for multiple versions. For instance, I had no way to connect to my work desktop between 13.5 and 13.9 due to this bug: https://discussions.citrix.com/topic/385459-ssl-error-with-135-works-with-134/page-2#entry1977735

Since—at the moment—there are no issues with using the latest version (at least for my use cases), I don't have an objection to deleting the old ones.

Finally, unless you have many different sets of certs that you wrap Citrix with, wouldn't it be simpler to pass your extraCerts argument to the main Citrix package to avoid the cognitive overhead of the wrapper for anyone looking at the package?

Technically we should also add citrix_receiver_13_6_0, citrix_receiver_13_5_0, and citrix_receiver_13_4_0 if we go down that route. I think maybe throws are fine for renamed attributes but not required for version specific attributes?

I agree with @infinisil here: we provide a proper error message now and I'd drop the attribute before the 19.09 branchoff. Then we need to package a newer Citrix version (which is not released yet) and deprecate 13.10 (which will be EOLed in december 2019).

IMHO this is just a helper to avoid confusion when updating, those attributes shouldn't stay here forever.

Since—at the moment—there are no issues with using the latest version (at least for my use cases), I don't have an objection to deleting the old ones.

Same here, using 13.10 for a while now for my work, I didn't experience severe problems that were caused by the receiver.

If we had known issues with several receiver versions I'd totally agree with you, but for now I guess we should simply drop all versions that are about to be EOLed.

Finally, unless you have many different sets of certs that you wrap Citrix with, wouldn't it be simpler to pass your extraCerts argument to the main Citrix package to avoid the cognitive overhead of the wrapper for anyone looking at the package?

I though keeping extra wrapping logic separated from the actual package is better and seems to be a common patter in nixpkgs (although citrix_receiver doesn't take long to rebuild). But IMHO that should be discussed as part of a different PR.

Pinging @obadz. It would be great to have this in the 19.03 release :)

Merged. Thx.

Backported as f4612a2. Those versions will be EOLed during the lifetime of 19.03, so we can entirely drop 13.{8,9} before the 19.09 branchoff.