Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/docker-registry: Allow use of non-filesystem storage #57546

Merged
merged 1 commit into from Mar 23, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 12, 2019

Motivation for this change

Previously this module precluded use of storage backends other than
filesystem. It is now possible to configure another storage backend
manually by setting services.dockerRegistry.storagePath to null and
configuring the other backend via extraConfig.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Previously this module precluded use of storage backends other than
`filesystem`. It is now possible to configure another storage backend
manually by setting `services.dockerRegistry.storagePath` to `null` and
configuring the other backend via `extraConfig`.
@bgamari bgamari requested a review from infinisil as a code owner March 12, 2019 22:23
@bgamari
Copy link
Contributor Author

bgamari commented Mar 12, 2019

CC @globin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants