Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfgrep: relax platform from linux to unix #57444

Merged
merged 1 commit into from
Mar 12, 2019
Merged

pdfgrep: relax platform from linux to unix #57444

merged 1 commit into from
Mar 12, 2019
+1 −1

Conversation

abathur
Copy link
Member

@abathur abathur commented Mar 11, 2019

Motivation for this change

Enable building pdfgrep on additional platforms. I couldn't find a clear statement on platform support, but it did build fine on macos with allowUnsupportedSystem = true and saw no issues after a fair amount of use. Close #56541.

Things done

Not in a position to clone nixpkgs to a system for further testing at the moment; I'm just making this change via github's online interface.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@abathur
pdfgrep: relax platform from linux to unix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
95aef95
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 11, 2019
@GrahamcOfBorg GrahamcOfBorg requested review from fpletz and qknight March 11, 2019 20:46
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 11, 2019
@xeji
Copy link
Contributor

xeji commented Mar 11, 2019

@GrahamcOfBorg build pdfgrep

@veprbl veprbl merged commit c3cb593 into NixOS:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@qknight qknight

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abathur @xeji @veprbl @GrahamcOfBorg