Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Cloudfront URLs with NixOS.org URLs #267

Merged
merged 1 commit into from Mar 17, 2019

Conversation

gurjeet
Copy link
Contributor

@gurjeet gurjeet commented Mar 11, 2019

In commit 70bcfbb the prefix of the download URLs was changed from

https://nixos.org/releases/nixos/...

to

https://d3g5gsiof5omrk.cloudfront.net/nixos/...

This doesn't seem ideal since the URL is pointing to a non-NixOS URL. I have
verified that the replacing the Cloudfront URL with https://releases.nixos.org/nixos/...
seems to work for all the URLs we care about.

Hence changing the prefix back to NixOS.org's site seems right thing to do.

In commit 70bcfbb the prefix of the download URLs was changed from

`https://nixos.org/releases/nixos/...`

to

`https://d3g5gsiof5omrk.cloudfront.net/nixos/...`

This doesn't seem ideal since the URL is pointing to a non-NixOS URL. I have
verified that the replacing the Cloudfront URL with `https://releases.nixos.org/nixos/...`
seems to work for all the URLs we care about.

Hence changing the prefix back to NixOS.org's site seems right thing to do.
@gurjeet
Copy link
Contributor Author

gurjeet commented Mar 15, 2019

bump...

/cc @edolstra

@domenkozar domenkozar requested a review from grahamc March 15, 2019 06:35
@gurjeet
Copy link
Contributor Author

gurjeet commented Mar 17, 2019

@domenkozar, thanks for assigning a reviewer to the issue!

@grahamc, I understand it's a minor update, but it'd be great to get a closure on the issue.

@grahamc
Copy link
Member

grahamc commented Mar 17, 2019

Thank you!

@grahamc grahamc merged commit 5526c05 into NixOS:master Mar 17, 2019
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nix-shell:~]$ dig releases.nixos.org

; <<>> DiG 9.12.3-P1 <<>> releases.nixos.org
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 7771
;; flags: qr rd ra; QUERY: 1, ANSWER: 5, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1280
;; QUESTION SECTION:
;releases.nixos.org. IN A

;; ANSWER SECTION:
releases.nixos.org. 3600 IN CNAME d3g5gsiof5omrk.cloudfront.net.
d3g5gsiof5omrk.cloudfront.net. 60 IN A 13.249.79.48
d3g5gsiof5omrk.cloudfront.net. 60 IN A 13.249.79.31
d3g5gsiof5omrk.cloudfront.net. 60 IN A 13.249.79.74
d3g5gsiof5omrk.cloudfront.net. 60 IN A 13.249.79.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants