-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
pythonPackages.weboob: fix build #57555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@GrahamcOfBorg build pythonPackages.weboob python3Packages.weboob |
Commit msg should be pr title with the : before the actual msg |
This should instead have been solved by adding |
Oh, so it can. TIL. I can redo it if you want? @dotlambda |
I think that would help with cross-compiling. |
I'm not sure how to do all of that. I'm new to this and not very good at it yet I'm afraid. I'm more available on Freenode IRC as DigitalKiwi if that'd help figure it out. |
Darn, I thought it was there and still didn't work for some reason. |
What do you mean by conditionally overriding from |
We can either an extra
|
Yep, that's what I thought you had in mind 👍 |
Motivation for this change
In the course of adding a package I had to update one of its dependencies (pdfminer) to a newer version, I found out that this weboob wouldn't build... (and that was unrelated to my changes)
Things done
I did the nox-review wip successfully
Voiced my frustrations on irc and simpson confirmed it wasn't only me and gave me a patch, which was nice as I had no idea how to fix it
I don't use this thing so I don't know what it is or how to use it but I ran some of the bins to see if they still worked (the few I checked didn't error)
Found out there's a new version of it anyway...
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)