Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.weboob: fix build #57555

Merged
merged 1 commit into from Mar 13, 2019
Merged

pythonPackages.weboob: fix build #57555

merged 1 commit into from Mar 13, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Mar 13, 2019

Motivation for this change

In the course of adding a package I had to update one of its dependencies (pdfminer) to a newer version, I found out that this weboob wouldn't build... (and that was unrelated to my changes)

Things done

I did the nox-review wip successfully
Voiced my frustrations on irc and simpson confirmed it wasn't only me and gave me a patch, which was nice as I had no idea how to fix it
I don't use this thing so I don't know what it is or how to use it but I ran some of the bins to see if they still worked (the few I checked didn't error)
Found out there's a new version of it anyway...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.weboob python3Packages.weboob

@worldofpeace worldofpeace changed the title pythonPackages.weboob fix build pythonPackages.weboob: fix build Mar 13, 2019
@worldofpeace
Copy link
Contributor

Commit msg should be pr title with the : before the actual msg

@worldofpeace worldofpeace merged commit f0bd271 into NixOS:master Mar 13, 2019
@worldofpeace
Copy link
Contributor

Backported in 22267de

Thanks @Kiwi ❇️

@dotlambda
Copy link
Member

This should instead have been solved by adding pyqt5 to nativeBuildInputs too.

@Kiwi
Copy link
Member Author

Kiwi commented Mar 13, 2019

Oh, so it can. TIL. I can redo it if you want? @dotlambda

@dotlambda
Copy link
Member

I think that would help with cross-compiling.
Btw, we should also remove that google_api_python_client_python27 from the expression and instead conditionally override the package on Python 2 from within python-packages.nix.

@Kiwi
Copy link
Member Author

Kiwi commented Mar 13, 2019

I'm not sure how to do all of that. I'm new to this and not very good at it yet I'm afraid. I'm more available on Freenode IRC as DigitalKiwi if that'd help figure it out.

@worldofpeace
Copy link
Contributor

This should instead have been solved by adding pyqt5 to nativeBuildInputs too.

Darn, I thought it was there and still didn't work for some reason.
I can make the other requested change with the override.

@worldofpeace
Copy link
Contributor

Btw, we should also remove that google_api_python_client_python27 from the expression and instead conditionally override the package on Python 2 from within python-packages.nix.

What do you mean by conditionally overriding from python-packages.nix?
I know you don't mean adding an older version 😄

@dotlambda
Copy link
Member

What do you mean by conditionally overriding from python-packages.nix?

We can either an extra old.nix and call this for Python 2 or, to follow DRY, use something like

google_api_python_client = let
  google_api_python_client = callPackage ...
in if isPy3k then google_api_python_client else
  google_api_python_client.overridePythonAttrs { ... };

@worldofpeace
Copy link
Contributor

to follow DRY, use something like

google_api_python_client = let
 google_api_python_client = callPackage ...
in if isPy3k then google_api_python_client else
 google_api_python_client.overridePythonAttrs { ... };

Yep, that's what I thought you had in mind 👍

@Kiwi Kiwi deleted the weboob-fix branch June 20, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants