Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pdfminer: 20170720 -> 20181108 #57556

Merged
merged 1 commit into from
Mar 13, 2019
Merged

pythonPackages.pdfminer: 20170720 -> 20181108 #57556

merged 1 commit into from
Mar 13, 2019
+5 −5

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Mar 13, 2019

Motivation for this change

In the course of adding a new package I found that it needed a newer version of pdfminer_six than we had so I updated to the latest version

Things done

i did a nox-review wip and other than the packages that didn't work anyway (see #57555) everything seems fine. Also successfully executed everything in bin

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Kiwi Kiwi requested a review from FRidh as a code owner March 13, 2019 01:17
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.pdfminer

@worldofpeace
Copy link
Contributor

Everything looks good, though you don't need the from in the commit msg.

@Kiwi Kiwi force-pushed the update-pdfminer-six branch from 7261b42 to ce207b2 Compare March 13, 2019 01:31
@Kiwi Kiwi changed the title pythonPackages.pdfminer: from 20170720 -> 20181108 pythonPackages.pdfminer: 20170720 -> 20181108 Mar 13, 2019
worldofpeace
worldofpeace reviewed Mar 13, 2019
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -5330,6 +5330,8 @@ in {

rubymarshal = callPackage ../development/python-modules/rubymarshal { };

ruffus = callPackage ../development/python-modules/ruffus { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably didn't mean for that to happen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I just realized on irc... :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the course of adding a new package

Just wanted to mention that if said package requires other deps that you need to package, you can do all of that in one pr.

Thanks, it does; and I wasn't sure how to do that and that makes it a lot easier to do than what I was going to... :)

@worldofpeace
Copy link
Contributor

In the course of adding a new package

Just wanted to mention that if said package requires other deps that you need to package, you can do all of that in one pr.

@Kiwi Kiwi force-pushed the update-pdfminer-six branch from ce207b2 to be1f482 Compare March 13, 2019 01:56
@worldofpeace
Copy link
Contributor

In the course of adding a new package

Just wanted to mention that if said package requires other deps that you need to package, you can do all of that in one pr.

Thanks, it does; and I wasn't sure how to do that and that makes it a lot easier to do than what I was going to... :)

You're welcome 😄

@worldofpeace worldofpeace merged commit c0f0305 into NixOS:master Mar 13, 2019
@worldofpeace
Copy link
Contributor

Thank you for contributing 😄

Btw, if the package you're going to add is purely python packaging, I'd be a good person to ping for review.

@Kiwi Kiwi deleted the update-pdfminer-six branch June 20, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kiwi @worldofpeace @GrahamcOfBorg