Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.8 -> 0.0.9 #57538

Closed
wants to merge 1 commit into from
Closed

discord: 0.0.8 -> 0.0.9 #57538

wants to merge 1 commit into from

Conversation

NickSeagull
Copy link

@NickSeagull NickSeagull commented Mar 12, 2019 •
edited

Motivation for this change

When using the current Discord derivation, a popup appears requesting to bump to 0.0.9,
I've made the version bump on my system, and it worked right away.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@NickSeagull #57528 got merged probably at the same time you opened this

@NickSeagull
Copy link
Author

Woops, thanks!

@NickSeagull NickSeagull deleted the patch-1 branch March 12, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NickSeagull @worldofpeace @GrahamcOfBorg @Janik-Haag