Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-raze: init at 0.2.8 #57437

Merged
merged 1 commit into from Jul 20, 2019
Merged

cargo-raze: init at 0.2.8 #57437

merged 1 commit into from Jul 20, 2019

Conversation

elasticdog
Copy link
Contributor

Motivation for this change

I'm working on packaging common tools used to manage multi-language monorepos with Bazel, and this is the current defacto means of generating BUILD files for Rust dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

@GrahamcOfBorg build cargo-raze

@elasticdog
Copy link
Contributor Author

I think the unexpected error from cargo-raze on x86_64-darwin might have been bad timing with a transient issue from GitHub's troubles earlier today.

unexpected return value from ssl handshake -9808

@aanderse
Copy link
Member

We can test that theory:

@GrahamcOfBorg build cargo-raze

@aanderse
Copy link
Member

Oops... Looks like a merge conflict skool be taken care of first.

@elasticdog
Copy link
Contributor Author

Since the time when I originally opened the PR, upstream has started doing legit releases, so I've rebased to fix the merge conflict, updated to the official versioning scheme, and force pushed. Not sure if I have the ability to trigger this, but...

@GrahamcOfBorg build cargo-raze

@elasticdog elasticdog changed the title cargo-raze: init at 2019-02-03 cargo-raze: init at 0.2.8 Jul 19, 2019
@aanderse
Copy link
Member

@GrahamcOfBorg build cargo-raze

@aanderse aanderse merged commit 87b4e9c into NixOS:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants