Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findnewest: init at 0.3 #57435

Merged
merged 5 commits into from Mar 12, 2019
Merged

findnewest: init at 0.3 #57435

merged 5 commits into from Mar 12, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 11, 2019

@GrahamcOfBorg build findnewest

pkgs/development/tools/misc/findnewest/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/findnewest/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/findnewest/default.nix Outdated Show resolved Hide resolved
ryantm and others added 3 commits March 12, 2019 12:45
Co-Authored-By: bhipple <bhipple@protonmail.com>
Co-Authored-By: bhipple <bhipple@protonmail.com>
Co-Authored-By: bhipple <bhipple@protonmail.com>
@bhipple
Copy link
Contributor Author

bhipple commented Mar 12, 2019

That's much nicer, thank you Ryan! Should I rebase and squash these or do you have a 1-click way to do this on the PR merge button?

@ryantm
Copy link
Member

ryantm commented Mar 12, 2019

I can use the squash and merge feature on GitHub.

Co-Authored-By: bhipple <bhipple@protonmail.com>
@ryantm ryantm merged commit c484d9b into NixOS:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants