Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libu2f-host: 1.1.7 -> 1.1.9 #57521

Closed
wants to merge 1 commit into from
Closed

libu2f-host: 1.1.7 -> 1.1.9 #57521

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 12, 2019

Motivation for this change

https://github.com/Yubico/libu2f-host/blob/master/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 13, 2019

Test failure on darwin and no build attempt on x86_64-linux. Let's try again.
@GrahamcOfBorg build libu2f-host pam_u2f yubikey-manager

@dtzWill dtzWill mentioned this pull request Mar 26, 2019
Closed
@dtzWill dtzWill mentioned this pull request Apr 5, 2019
Closed
timokau
timokau requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin ofBorg failure. CC @NixOS/darwin-maintainers

@bkchr
Copy link
Contributor

bkchr commented Apr 25, 2019

Any update on this?

@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

It was updated in #59571

@c0bw3b c0bw3b closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtzWill @xeji @bkchr @c0bw3b @timokau @infinisil @GrahamcOfBorg