Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piper: 0.2.902 -> 0.2.903 #54770

Merged
merged 1 commit into from Feb 24, 2019
Merged

piper: 0.2.902 -> 0.2.903 #54770

merged 1 commit into from Feb 24, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

infinisil commented Jan 28, 2019 •
edited

@GrahamcOfBorg eval

Weird that it doesn't restart eval, I broke it for a bit on master by accident

@xeji
Copy link
Contributor

xeji commented Feb 24, 2019

@GrahamcOfBorg build piper

@jtojnar
Copy link
Contributor

jtojnar commented Feb 24, 2019 •
edited

changes: libratbag/piper@0.2.902...0.2.903

@ryantm ryantm merged commit e08a891 into NixOS:master Feb 24, 2019
@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@tadeokondrak thanks; please consider adding yourself as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tadeokondrak @infinisil @xeji @jtojnar @ryantm @dywedir @GrahamcOfBorg