Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

birdfont: init at 2.25.0 (and add dep xmlbird) #54749

Merged
merged 2 commits into from Jan 31, 2019
Merged

birdfont: init at 2.25.0 (and add dep xmlbird) #54749

merged 2 commits into from Jan 31, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 28, 2019

Motivation for this change

Haven't used it much but seems to work properly :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

Can you add a meta attribute, at least on birdfont ?

@dtzWill
Copy link
Member Author

dtzWill commented Jan 29, 2019

Eep, of course! Haha my mistake, will add shortly...

@dtzWill
Copy link
Member Author

dtzWill commented Jan 29, 2019

FWIW the open-source version is apparently quite a bit behind the free-but-closed-source version, which is available from their website as a flatpak. I struggled slightly with both but oh well :).

@dtzWill dtzWill merged commit 70f56d8 into NixOS:master Jan 31, 2019
@dtzWill dtzWill deleted the feature/birdfont branch January 31, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @symphorien @GrahamcOfBorg