Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.ms-vscode.cpptools: 0.20.1 -> 0.21.0 #54751

Merged

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jan 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build vscode-extensions.ms-vscode.cpptools

@worldofpeace
Copy link
Contributor

@eadwu I get this warning when building locally

substituteStream(): WARNING: pattern '"default": "/usr/bin/gdb"' doesn't match anything in file './package.json'

@eadwu
Copy link
Member Author

eadwu commented Feb 8, 2019

Just checked the build log, I get it as well, however, miDebuggerPath seems to be patched up all nicely in package.json so that might just be a redundant piece of code?

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 9, 2019

Just checked the build log, I get it as well, however, miDebuggerPath seems to be patched up all nicely in package.json so that might just be a redundant piece of code?

Possibly, If the result looks right I see no reason not to merge this 👍

@worldofpeace worldofpeace merged commit baf6ba5 into NixOS:master Feb 9, 2019
@eadwu eadwu deleted the vscode-extensions.ms-vscode.cpptools/0.21.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants