Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_testing_bcachefs,bcachefs-tools: 20190123 #54752

Merged
merged 2 commits into from Feb 4, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jan 28, 2019

Motivation for this change

Turns out the version have to be in sync in order for mount -t bcachefs to work, sad 2 days. bcachefs format --encrypted is still broken so yeah.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg test bcachefs

@dywedir dywedir merged commit 8626808 into NixOS:master Feb 4, 2019
@hyperfekt
Copy link
Contributor

How is encrypted format broken for you? I just formatted with encryption, unlocked and mounted so I'm not sure what the problem is. Are you referring to #32279?

@eadwu
Copy link
Member Author

eadwu commented Feb 9, 2019

Yep, #32279 is pretty much what happened.

@hyperfekt
Copy link
Contributor

hyperfekt commented Feb 9, 2019

How well tested is this bcachefs version?
It gets stuck on fdatasync for me when trying to install NixOS on it.

@eadwu
Copy link
Member Author

eadwu commented Feb 9, 2019

I'm running it fine right now, albeit with some changes currently, manually made a patch for the latest kernel stable version (4.20.7) since the bcachefs repository is somewhat behind on the latest stable. Personally, I tested linux_testing_bcachefs before I made the PR, since bcachefs-tools and bcachefs were out of sync beforehand. Though unecrypted from bcachefs format, as stated above.

@hyperfekt
Copy link
Contributor

Is there a chance you can try to replicate koverstreet/bcachefs#16? If it doesn't occur without encryption you could cherry-pick #30333 (which isn't needed in initramfs and thus only necessary on the ISO used to install).

@hyperfekt
Copy link
Contributor

hyperfekt commented Feb 9, 2019

Note that the commit the kernel is picked from has since been amended as such

diff --git a/fs/bcachefs/btree_gc.h b/fs/bcachefs/btree_gc.h
index 1905acfa028a..8af5f841a537 100644
--- a/fs/bcachefs/btree_gc.h
+++ b/fs/bcachefs/btree_gc.h
@@ -109,7 +109,7 @@ static inline bool gc_visited(struct bch_fs *c, struct gc_pos pos)
 
        do {
                seq = read_seqcount_begin(&c->gc_pos_lock);
-               ret = gc_pos_cmp(pos, c->gc_pos) < 0;
+               ret = gc_pos_cmp(pos, c->gc_pos) <= 0;
        } while (read_seqcount_retry(&c->gc_pos_lock, seq));
 
        return ret;

@eadwu
Copy link
Member Author

eadwu commented Feb 9, 2019

I'll try tonight when I have more spare time, though the kernel issue doesn't really affect me right now since I have a patch containing all the commit diffs up to the previous revision (before the amend). As for bumping the revision on nixpkgs, I think it should be safe to assume that a new target for bcachefs{-tools} should come out relatively soon.

@hyperfekt
Copy link
Contributor

Looks like people should refrain from using zstd for now, see the linked issue. I thought it was just something weird about my system but looks like that is at fault - I don't think you have to reproduce now that we've found the factor.

@eadwu eadwu deleted the bcachefs/20190123 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants