Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurp: init at 1.0 #54812

Closed
wants to merge 1 commit into from
Closed

slurp: init at 1.0 #54812

wants to merge 1 commit into from

Conversation

FlorianFranzen
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Maintainer is defined in #54627.

@dywedir
Copy link
Member

dywedir commented Jan 28, 2019

Similar PR: #54568

@FlorianFranzen
Copy link
Contributor Author

@dywedir My bad. Not sure how I missed that.

@nlewo
Copy link
Member

nlewo commented Jan 29, 2019

Closed since #54568 has been merged.

@nlewo nlewo closed this Jan 29, 2019
@FlorianFranzen
Copy link
Contributor Author

@nlewo Thanks.

@FlorianFranzen FlorianFranzen deleted the slurp branch February 10, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FlorianFranzen @dywedir @nlewo