Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdroidserver: 2016-05-31 -> 1.1 #54813

Merged
merged 4 commits into from Jan 30, 2019
Merged

fdroidserver: 2016-05-31 -> 1.1 #54813

merged 4 commits into from Jan 30, 2019

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

This needs a few new Python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner January 28, 2019 14:54
@pmiddend
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.fdroidserver

dotlambda
dotlambda requested changes Jan 28, 2019
View reviewed changes
pkgs/development/python-modules/androguard/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/androguard/default.nix Show resolved Hide resolved
pkgs/development/python-modules/androguard/default.nix Show resolved Hide resolved
pkgs/development/python-modules/docker-py/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/docker-py/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vagrant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vagrant/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vagrant/default.nix Show resolved Hide resolved
pkgs/development/python-modules/docker-py/default.nix Show resolved Hide resolved
pkgs/development/python-modules/fdroidserver/default.nix Outdated Show resolved Hide resolved
@pmiddend pmiddend force-pushed the fdroidserver-update branch 2 times, most recently from 8c3339c to d169611 Compare January 28, 2019 15:41
@pmiddend pmiddend force-pushed the fdroidserver-update branch 2 times, most recently from 6cdd14c to 701fed2 Compare January 29, 2019 09:32
@pmiddend pmiddend changed the title python3Packages.fdroidserver: 2016-05-31 -> 1.1a python3Packages.fdroidserver: 2016-05-31 -> 1.1 Jan 29, 2019
@pmiddend
Copy link
Contributor Author

@dotlambda I've fixed all the issues. 1.1 was released yesterday, so I upgraded my expression to that version (and also moved to buildPythonApplication).

dotlambda
dotlambda reviewed Jan 29, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit message should be something like fdroidserver: 2016-05-31 -> 1.1 and move out of pythonPackages.

pkgs/development/python-modules/python-vagrant/default.nix Outdated
};

checkInputs = [ vagrant ];
checkPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been changed.

pkgs/development/tools/fdroidserver/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/fdroidserver/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda changed the title python3Packages.fdroidserver: 2016-05-31 -> 1.1 fdroidserver: 2016-05-31 -> 1.1 Jan 29, 2019
@pmiddend pmiddend force-pushed the fdroidserver-update branch 2 times, most recently from a7a0f49 to 4465e76 Compare January 29, 2019 20:43
@pmiddend
Copy link
Contributor Author

@dotlambda Fixed all of the findings. I had to disable tests for python-vagrant, when patched the right way, they seem to interact with qemu in some way.

dotlambda
dotlambda requested changes Jan 29, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message for python-vagrant should be corrected.

pkgs/development/python-modules/python-vagrant/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

Building androguard, I get

Ran 0 tests in 0.000s

Hence, a proper checkPhase needs to be added or - if there are no tests - doCheck = false should be set and a comment with the reason be added.

@pmiddend pmiddend force-pushed the fdroidserver-update branch 2 times, most recently from bdd6914 to e51e992 Compare January 29, 2019 22:15
@pmiddend
Copy link
Contributor Author

@dotlambda There were indeed no tests, at least in the package from pypi.

@pmiddend
Copy link
Contributor Author

@dotlambda Thanks for the thorough review. Fixed.

dotlambda
dotlambda requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for so many reviews. This is the last one.

pkgs/development/python-modules/docker-py/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

@GrahamcOfBorg build fdroidserver

@pmiddend
Copy link
Contributor Author

@dotlambda Nah, I'm sorry for the lack of care. Thanks for being patient.

@dotlambda dotlambda merged commit dfc8ec8 into NixOS:master Jan 30, 2019
@pmiddend pmiddend deleted the fdroidserver-update branch January 30, 2019 09:33
davidtwco added a commit to davidtwco/veritas that referenced this pull request Nov 29, 2019
@davidtwco
Implement alternate approach to ComputeCpp wrapping.
b5f99c3 
This approach uses the foundations laid in NixOS/nixpkgs#54813 so that
this package will eventually be upstreamable.
davidtwco added a commit to davidtwco/veritas that referenced this pull request Nov 29, 2019
@davidtwco
Implement alternate approach to ComputeCpp wrapping.
423e1d2 
This approach uses the foundations laid in NixOS/nixpkgs#54813 so that
this package will eventually be upstreamable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @dotlambda @GrahamcOfBorg