Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind11: 2.2.2 -> 2.2.4 #54792

Merged
merged 1 commit into from Feb 14, 2019
Merged

pybind11: 2.2.2 -> 2.2.4 #54792

merged 1 commit into from Feb 14, 2019

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Update pybind11 to latest release.

Also enable the included test suite again, apart from mock install based test_cmake_build test, which always fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FlorianFranzen
Copy link
Contributor Author

@yuriaisaka Any interested in taking a look at this?

@FlorianFranzen
Copy link
Contributor Author

@dotlambda Now that you had some exposure to pybind11, would you mind reviewing this one as well?

@dotlambda
Copy link
Member

@FlorianFranzen Thanks a lot for enabling the tests!

@FlorianFranzen
Copy link
Contributor Author

@dotlambda: No problem. Thank you for the feedback. I just updated the expression with your proposed correction.

Furthermore the test failure we are currently seeing in now also documented in detail in the linked upstream issue.

@dotlambda
Copy link
Member

@GrahamcOfBorg build pybind11

@dotlambda dotlambda merged commit 59379d1 into NixOS:master Feb 14, 2019
@FlorianFranzen FlorianFranzen deleted the pybind branch February 14, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FlorianFranzen @dotlambda @GrahamcOfBorg