Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: 1.3.0 -> 1.4.1 #54803

Merged
merged 1 commit into from Feb 14, 2019
Merged

consul: 1.3.0 -> 1.4.1 #54803

merged 1 commit into from Feb 14, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 28, 2019

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to most recent release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@infinisil
Copy link
Member

@GrahamcOfBorg build consul

@infinisil
Copy link
Member

Have you checked to see if the NixOS module still works?

And pinging the other maintainers as well, @pradeepchhetri @nh2

@vdemeester
Copy link
Member Author

@infinisil ah good point, I'll check tomorrow morning 👼

@arianvp
Copy link
Member

arianvp commented Feb 10, 2019

@vdemeester have you still checked this?

@nh2
Copy link
Contributor

nh2 commented Feb 11, 2019

I've tested it on my staging cluster, works for me.

@infinisil infinisil merged commit 718b701 into NixOS:master Feb 14, 2019
@vdemeester vdemeester deleted the update-consul branch February 15, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants