Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rfc3986: fix pytest dependency #57119

Merged
merged 2 commits into from Mar 9, 2019
Merged

pythonPackages.rfc3986: fix pytest dependency #57119

merged 2 commits into from Mar 9, 2019

Conversation

sveitser
Copy link
Contributor

@sveitser sveitser commented Mar 9, 2019 •
edited

Motivation for this change

Build fails with

/nix/store/63karsgdg7fm3q0if4zfd7apbd8ac1ci-stdenv-linux/setup: line 1311: py.test: command not found

https://hydra.nixos.org/build/89616980/nixlog/1/tail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser sveitser requested a review from FRidh as a code owner March 9, 2019 13:43
@worldofpeace @sveitser
Replace deprecated py.test command with pytest
47dd2b4 
Co-Authored-By: sveitser <sveitser@gmail.com>
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.rfc3986 python3Packages.rfc3986

FRidh
FRidh reviewed Mar 9, 2019
View reviewed changes
pkgs/development/python-modules/rfc3986/default.nix
checkPhase = ''
py.test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nevermind, I did not know pytest was the preferred invocation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but might as well change it right?

@worldofpeace worldofpeace merged commit 40953c8 into NixOS:master Mar 9, 2019
@worldofpeace
Copy link
Contributor

🤣 That should have been a squash

@worldofpeace
Copy link
Contributor

Backported in 1b97770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sveitser @worldofpeace @FRidh @GrahamcOfBorg