-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
lsd: init at 0.13.0 #57116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsd: init at 0.13.0 #57116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds, functions properly.
Tested completions for bash successfully when installed with nix-env
.
However they didn't work with zsh
or fish
.
Thanks for your review!
I used the completions paths which are commonly used in other nix expressions: I personally use bash, but I've tested on zsh and seems to be working |
I just failed to build this on macOS.
|
I don't have |
|
That is odd, I'm building it on darwin 10.12 without any issue.
maybe nix-daemon is running with sandbox=true, can you try restarting nix-daemon? |
I've got a single-user install so no |
The simplest solution here might just be to disable tests on this package. I notice the
|
Motivation for this change
Add lsd https://github.com/Peltoche/lsd
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)