Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pivy: 20101207 -> 0.6.5a1pre #57121

Closed
wants to merge 4 commits into from

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Updates coin3d, soqt and pivy to latest version. I was able to upstream most of the patches quickly but one is still outstanding.

pivy is now installed from the repository managed by FreeCAD, as it contains a lot important patches we would need to apply anyway. I choose a pre release version, because upstream failed to release a version so far that contains all of debians patches.

Main software that uses pivy is freecad, which I briefly tested as well.

Also addresses #54491.

Things to do
  • Depends on qtbase: Fix paths returned by qmake -query #57097 being merged into staging and then master, because pivy uses qmake -query to find its dependencies. The needed commit is included to simplify testing.

  • Secondly, testing of coin3d and pivy also needs to be fixed, as it is available but broken.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member

gebner commented Aug 8, 2019

Oops, I didn't see this when upgrading the FreeCAD dependencies in #63348. We now have newer versions of all of the packages touched by this PR.

@gebner gebner closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants